Open
Conversation
Adapted changes from https://github.com/solokeys/solo1-cli/pull/169/files
|
@Lgmrszd this is working fine for me, thank you for working on this. Any chance to wrap it up soon? |
Author
|
@kalbasit I will mark this as ready to review but I think this still needs more testing since I really haven't this much, unless you think it's working allright |
|
@Lgmrszd I played with it for some time, and I didn't get any errors so I believe it's working; With that said, I have not tested every path to know it works 100% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapted changes from
solokeys#169
Allows using fido2 library version 1.1.3
Haven't tested this much yet, draft for now